[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to using cosine similarity for abundance comparisons #69

Merged
merged 6 commits into from
Jan 3, 2017

Conversation

ctb
Copy link
Contributor
@ctb ctb commented Dec 31, 2016
  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb
Copy link
Contributor Author
ctb commented Dec 31, 2016
  • test 0 denom
  • verify dot-prod code

@ctb ctb changed the title switch to using dot product for abundance comparisons switch to using cosine similarity for abundance comparisons Jan 1, 2017
@codecov-io
Copy link
codecov-io commented Jan 1, 2017

Current coverage is 76.59% (diff: 96.82%)

Merging #69 into master will decrease coverage by 2.64%

@@             master        #69   diff @@
==========================================
  Files            17         17          
  Lines          2216       2273    +57   
  Methods          46         46          
  Messages          0          0          
  Branches         84         84          
==========================================
- Hits           1756       1741    -15   
- Misses          435        507    +72   
  Partials         25         25          

Powered by Codecov. Last update dd18fdd...32789a5

@ctb
Copy link
Contributor Author
ctb commented Jan 1, 2017

Ready for review & merge!

@ctb
Copy link
Contributor Author
ctb commented Jan 2, 2017

Ready for review & merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants