[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Prevented Running the CI If Only the Documentation Is Updated #2600

Conversation

ueqri
Copy link
Contributor
@ueqri ueqri commented Jun 7, 2024

Solved #2598.

Added a path-ignore filter to the GitHub Actions triggers (including push and pull_request) to filter out any push or pull request that only includes docs updates.

The "Test" and "Containers" workflows will be skipped if a push or a PR only contains changes to the documentation, such as the developer guide and README, so that we can save CI resources for other uses.

For more details, please refer to the issue page :)

Added a `path-ignore` filter to the GitHub Actions triggers (including
`push` and `pull_request`) to filter out any push or pull request that
only includes docs updates.

The "Test" and "Containers" workflows will be skipped if a push or a PR
only contains changes to the documentation, such as the developer guide
and README, so that we can save CI resources for other uses.
@ueqri
Copy link
Contributor Author
ueqri commented Jun 7, 2024

Another PR for #2545 will be opened as a test case (to verify that this CI change works) after this PR is merged.

@github-actions github-actions bot added the infra Project Infrastructure label Jun 7, 2024
@vaughnbetz
Copy link
Contributor

Will CI still build the documentation? That is useful ... you can ensure read the docs builds and look at the rendered/built documentation in advance of merging the PR. I agree other tests are not useful in that case, but the read the docs build should be preserved.

@ueqri
Copy link
Contributor Author
ueqri commented Jun 10, 2024

Will CI still build the documentation?

Yes. The online documentation build is relying on the Read the Docs CI currently, automatically triggered based on the .readthedocs.yaml. The Read the Docs CI is independent from GitHub Actions CI, and will as usual be triggered whenever there is a push to the master branch. Therefore, skipping all the current GitHub CI workflows won't affect the current online documentation build.

@vaughnbetz
Copy link
Contributor

Great, thanks!

@vaughnbetz vaughnbetz merged commit 14253d2 into verilog-to-routing:master Jun 10, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Project Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants