[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom elements #1854

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Support custom elements #1854

merged 2 commits into from
Nov 17, 2021

Conversation

jonathantneal
Copy link
Contributor

Changes

Testing

  • cannot confirm locally
  • local tests are failing before making any change

Docs

bug fix only

@changeset-bot
Copy link
changeset-bot bot commented Nov 17, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: dd8f30f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
netlify bot commented Nov 17, 2021 •
edited
Loading

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: dd8f30f

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/619554bcfd80630007a38c70

😎 Browse the preview: https://deploy-preview-1854--astro-www.netlify.app

@netlify
Copy link
netlify bot commented Nov 17, 2021 •
edited
Loading

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: dd8f30f

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/619554bca8891a0007320f8e

😎 Browse the preview: https://deploy-preview-1854--astro-docs-2.netlify.app

@jonathantneal jonathantneal marked this pull request as ready for review November 17, 2021 13:23
@jonathantneal jonathantneal requested a review from a team as a code owner November 17, 2021 13:23
@matthewp
Copy link
Contributor

lgtm. I think we can ignore the Netlify failures (but someone, like me, should look into fixing that).

@natemoo-re
Copy link
Member

I think this should wait, I have a feeling this doesn't fix the underlying problem. Fortunately, I think I know how to fix it! Will open a PR shortly.

@jonathantneal
Copy link
Contributor Author

Hey @natemoo-re, did the fix end up being a bit trickier?

This fix still seems appropriate if a custom element makes its way thru this code. Still prefer to hold?

@natemoo-re
Copy link
Member

@jonathantneal Nope, just got lost in the HMR issues. Picking this back up, will have an update shortly.

Jonathan Neal and others added 2 commits November 17, 2021 13:08
@natemoo-re
Copy link
Member

@jonathantneal pushed an update to your branch! Your approach was correct, I just simplified it a bit. We just have to check if Component is not a string.

@jonathantneal jonathantneal merged commit 739d3b9 into withastro:main Nov 17, 2021
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@jonathantneal
Support custom elements (withastro#1854)
8439370 
* Support custom elements

Support non-object/non-function components

* fix: ensure component is not string before throwing

Co-authored-by: Nate Moore <nate@skypack.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Astro does not support Custom Elements
3 participants
@jonathantneal @matthewp @natemoo-re