-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom elements #1854
Support custom elements #1854
Conversation
|
✔️ Deploy Preview for astro-www ready! 🔨 Explore the source changes: dd8f30f 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/619554bcfd80630007a38c70 😎 Browse the preview: https://deploy-preview-1854--astro-www.netlify.app |
✔️ Deploy Preview for astro-docs-2 ready! 🔨 Explore the source changes: dd8f30f 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/619554bca8891a0007320f8e 😎 Browse the preview: https://deploy-preview-1854--astro-docs-2.netlify.app |
lgtm. I think we can ignore the Netlify failures (but someone, like me, should look into fixing that). |
I think this should wait, I have a feeling this doesn't fix the underlying problem. Fortunately, I think I know how to fix it! Will open a PR shortly. |
Hey @natemoo-re, did the fix end up being a bit trickier? This fix still seems appropriate if a custom element makes its way thru this code. Still prefer to hold? |
@jonathantneal Nope, just got lost in the HMR issues. Picking this back up, will have an update shortly. |
Support non-object/non-function components
@jonathantneal pushed an update to your branch! Your approach was correct, I just simplified it a bit. We just have to check if Component is not a string. |
* Support custom elements Support non-object/non-function components * fix: ensure component is not string before throwing Co-authored-by: Nate Moore <nate@skypack.dev>
Changes
Testing
Docs
bug fix only