[go: nahoru, domu]

Skip to content

Commit

Permalink
Deps: Add androidx activity dependency (1.5.1)
Browse files Browse the repository at this point in the history
This dependency is added in order to access the activity related
'addMenuProvider(...)' API, which is not available prior to the
AndroidX Activity 1.4.0 release, see below:

https://developer.android.com/jetpack/androidx/releases/activity
#1.4.0-alpha01

Currently, and although the project is indeed using AndroidX Activity as
a transitive dependency, those point to older versions of it. Below is a
breakdown per module, and in parenthesis, the version it uses:
- image-editor (1.2.4)
- editor (1.1.0)
- WordPress (1.3.1)

FYI: The activity related 'addMenuProvider(...)' API is needed because
otherwise the 'Options Menu' migration can't commence.

------------------------------------------------------------------------

Release Notes: https://developer.android.com/jetpack/androidx/releases/
activity#1.5.1

------------------------------------------------------------------------

Note that the '1.6.1' update requires libraries and applications that
depend on it to compile against version 33 (Android 13) or later of the
Android APIs. However, this project is currently compiled against
android-31 (Android 12).

Thus, until the 'compileSdkVersion' of this project gets updated to '33'
updating to '1.9.0' isn't possible.

------------------------------------------------------------------------
  • Loading branch information
ParaskP7 committed Dec 23, 2022
1 parent ed27a93 commit 9aa97e3
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions WordPress/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,8 @@ dependencies {
implementation "androidx.lifecycle:lifecycle-common:$androidxLifecycleVersion"
implementation "androidx.lifecycle:lifecycle-runtime:$androidxLifecycleVersion"
implementation "androidx.lifecycle:lifecycle-runtime-ktx:$androidxLifecycleVersion"
implementation "androidx.activity:activity:$androidxActivityVersion"
implementation "androidx.activity:activity-ktx:$androidxActivityVersion"
implementation "androidx.fragment:fragment:$androidxFragmentVersion"
implementation "androidx.fragment:fragment-ktx:$androidxFragmentVersion"
implementation "androidx.multidex:multidex:$androidXMultidexVersion"
Expand Down
1 change: 1 addition & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ ext {
androidxConstraintlayoutVersion = '1.1.3'
androidxCoreVersion = '1.8.0'
androidxEmojiVersion = '1.0.0'
androidxActivityVersion = '1.5.1'
androidxFragmentVersion = '1.5.5'
androidxGridlayoutVersion = '1.0.0'
androidxLifecycleVersion = '2.5.1'
Expand Down
2 changes: 2 additions & 0 deletions libs/image-editor/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ repositories {
dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])

implementation "androidx.activity:activity:$androidxActivityVersion"
implementation "androidx.activity:activity-ktx:$androidxActivityVersion"
implementation "androidx.fragment:fragment:$androidxFragmentVersion"
implementation "androidx.appcompat:appcompat:$androidxAppcompatVersion"
implementation "androidx.constraintlayout:constraintlayout:$androidxConstraintlayoutVersion"
Expand Down

0 comments on commit 9aa97e3

Please sign in to comment.