Menu Drawer Item refactor #1

beaucollins · 2013-04-10T18:07:21Z

While preparing to put in a new menu item I found it a little difficult tracking all of the places in WPActionBarActivity that tracked which menu items are available/highlighted and what to do when they were selected.

Since the MenuDrawerItem class already existed this expands its functionality and provides a way to configure visibility/selection state and its action all in one place.

The main gist is that WPActionBarActivity now has a private list of available MenuDrawerItems. When updating the menu each item is asked if it should be displayed. Then in the AdapterView.OnItemClickListener picks the MenuDrawerItem off the MenuAdapter and fires its onSelectItem.

…visibility - WPActionBarActivity no longer needs a giant switch statement to figure out what to do when an item is selected - The action to perform is now associated directly to the menu item - Adding an item to the menu is now configured in a single location

…lass

beaucollins · 2013-04-10T18:10:17Z

The biggest benefit is that adding/removing new menu items is a little simpler to manage.

beaucollins · 2013-04-10T18:27:46Z

Has been tested and works with single vs multiple blogs as well as dotcom vs dotorg blogs.

Menu Drawer Item refactor

…ch-calls Use Volley native listeners instead our implementation

…plugin Setting up project to use wordpress gradle plugin

Move ptr to utils

86805a0 Add 'libs/utils/' from commit '94d1dbb0f5220525759de83c60cba3e95ce95eff' cfc3ff0 use title/content params in the editor 9f26eb3 remove useless test in example 83ff559 fix appcompat and support-v4 dependencies 714eeb1 move new editor logic to a fragment 4a2f1ba back to 21.1.1 tools 279f2ee fix appcompat dependency d3985f0 new travis config ee42dda fix build for example project 66fb19b rename package name to org.wordpress.android b61040c rename package name to org.wordpress.android 4edc93f add signing to publish artifact 94d1dbb Merge branch 'release/3.7' into develop 8ff9413 fix AppLogViewerActivity when a log is message is null 7c208db Merge pull request #2264 from wordpress-mobile/issue/2222-theme-preview-title 9eb7273 new BlogUtils.getHostNameFromAccountMap function a80859d Theme live preview no longer changes the activity title 6186933 Photo viewer now uses low quality for the lo-res image 2eb9839 Simplified comments bfa7ecb Switched to quality enum which defaults to medium a2ce056 Added default quality param to photon 5a48a06 html encode log entries in AppLog.toHtml() c8a4d89 fix #103: retain menu drawer scroll position after switching activities c1e0778 Merge branch 'develop' into issue/985-make-sfactory-private fe1d125 fix build files for android studio 1.0 f7a2d48 Merge remote-tracking branch 'origin/develop' into issue/985-make-sfactory-private 72fe2b7 update support lib version for travis 0b03b71 Merge branch 'develop' of https://github.com/wordpress-mobile/WordPress-Android into feature/material-appcompat 0f5751d Merge branch 'develop' into release/3.4 b68f755 remove unused code (refresh button) cb8321b fix #985: maks sFactory private - force injection in test module faae1d3 Merge branch 'release/3.4' into issue/1982-simperium-concurrency Conflicts: WordPress/src/main/java/org/wordpress/android/models/Note.java a0982d1 Updated build.gradle to specify com.android.support:appcompat-v7:21.0.2 3a0c45e Removed unsuccessful fix for #1982. b967d59 first step at replacing PreferenceActivity by a PreferenceFragment + ActionBarActivity 92d4e15 Merge branch 'develop' into feature/material-appcompat 7c8d5ab Merge branch 'release/3.4' into develop 1e499a6 Merge branch 'hotfix/3.3.1' into release/3.4 7a4a364 Merge branch 'develop' of https://github.com/wordpress-mobile/WordPress-Android into feature/material-appcompat 5451df7 update subtrees to use build tools 21.1.1 4024637 rename PullToRefresh to SwipeToRefresh 0d8d414 remove unused viewClass in PTR constructor 2424201 fix circle spinner color style d392885 Return a copy of the JSONObject in getDiffableValue(). 106affa replace Chris Banes' PullToRefresh by the native SwipeToRefresh view 3108a36 Merge remote-tracking branch 'origin/develop' into feature/1961-add-mentions-to-commenting db25827 Merge branch 'develop' into issue/1958-round-avatars 2801610 Merge remote-tracking branch 'origin/develop' into feature/1961-add-mentions-to-commenting 6ac0248 Merge branch 'hotfix/3.3.1' into release/3.4 eb70e6f upgrade to android-gradle 0.14.0 9bc4ba6 Rounds all WPNetworkImageViews with `AVATAR` type. c2fd6c7 Initial commit adding mentions to notification comments 0a3da42 Added image spans directly instead of using Html.fromHtml(). 5b22440 Merge branch 'release/3.2' into develop 1a2a73f fix debug/release build propagation to sub projects d9eac2e Merge branch 'release/3.2' into develop 380ece6 Merge pull request #1861 from wordpress-mobile/feature/notifications-redesign c38f131 Merge pull request #1860 from wordpress-mobile/issue/1821-remove-istablet 4e92eaa Merge branch 'hotfix/3.1.2' into release/3.2 cbc7b24 fix #1821: remove DisplayUtis.isTablet() method 343771a Catch NPE in Bitmap.CreateBitmap and make sure the returned bitmap is not null c44a87a Merge branch 'release/3.2' into feature/notifications-redesign 97c557c Revert "Revert "Merge pull request #1799 from wordpress-mobile/feature/1795-reader-render-attachments"" 1cacaf2 Merge branch 'hotfix/3.1.1' into release/3.2 568782f Merge branch 'hotfix/3.1.1' into develop 96fd180 remove isTablet() check 870944d Merge branch 'release/3.2' into feature/notifications-redesign 3390393 Revert "Merge pull request #1799 from wordpress-mobile/feature/1795-reader-render-attachments" 03bbac0 Merge branch 'develop' into feature/notifications-redesign 8ec2915 Replaced String.format() with string concatenation in ReaderUtils and PhotonUtils after profiler showed String.format() to be hurting performance 1623d65 fix lint error in utils e273dd3 Merge branch 'develop' into feature/notifications-redesign 4bfc641 Removed aggressive `JSONUtil` logging f7f4556 update support-v13 library to version 19.1.0 fafcf67 Merge pull request #1781 from wordpress-mobile/issue/17760-reader-comment-full-images 1868cc5 disable refresh on the attacher 082c13f use the PTR library version 0.9.7 f21f5d3 set network refresh mode as default d262f8d remove unused code 9e592fd add a network mode in PullToRefreshHeaderTransformer to show a different message when network is disabled f85a003 move NetworkUtils to WPUtils subtree d19c080 Updated comment cabb8a7 TextView content is reset to itself to force it to correctly resize using cached image 48e4ed2 More cleanup 2426243 Cleanup WPImageGetter based on code analysis c955d26 Merge pull request #1764 from wordpress-mobile/issue/1713-send-version-code-to-mixpanel 3bc1080 Merge branch 'release/3.1' into develop f75a9e7 increment version number caa9db0 fix #1762: show blog url in the share blog spinner if the blog title is an empty string e1eecbf remove ProfilingUtils.getVersionName calls 075b989 remove unused method from ProfilingUtils b48cbda move BuildUtils to WPUtils subtree, rename BuildUtils to PackageUtils and add getPackageInfo and getVersionCode methods 44bb61e Rewrote the AppLog viewer to use a ListView+adapter 59f0bfa Merge branch 'develop' into issue/1690-track-last-seen-screen 9300d28 remove unused util file ActivityUtils b15cf64 Bump libs/utils version number. 0d89a80 generic way to track last seen activity - requires GET_TASKS permission 391276c Use the unicode version of the Horizontal ellipsis char. Restrict the visibility of some methods to private. c8dc1e8 Text view that auto adjusts text size to fit within the view.If the text size equals the minimum text size and still does not fit, append with an ellipsis. aa5b665 init utils readme 76df52f import libs/utis 449639d set defaultPublishConfig to debug - in case we had source dependencies to this module 5b1f8f1 remove gradle wrapper cd72102 Bump version number 90f9f22 Merge pull request #1 from wordpress-mobile/issue/move-ptr-to-utils c6b0ff9 showToast methods now return a Toast object 3e93210 Move pull to refresh to Utils b302b44 Move ToastUtils to Utils a0e973c document getPrimaryEmail method d68fb87 add getCircularBitmap and getRoundedEdgeBitmap from the main project merge in 80014b7 d2a76e2 avoid build failure when gradle.properties file is missing 5d683f6 use maven plugin to deploy maven artifact 70a91cb bump version number to 1.0.1 575579d gitignore tools/deploy-mvn-artifact.conf 50f2c80 maven deploying script cf85e19 ignore .idea and local.properties 7c6d4f4 add WPImageGetter and fix HtmlUtils b4baff8 remove crashlytics reference from Utils 32e98a9 merge from WordPress-Android@1a74364d0 79b7014 gitignore all build/ directories c9e6b52 Restores query separator period in `JSONUtils`. fddb5a0 Ignoring iml files 4263343 Initial commit of utils classes. 0228ac4 Fix package id name 826c265 Move java source to correct directory a528b8e Initial Project Structure git-subtree-dir: libs/editor git-subtree-split: 86805a0

Added a build status image

Merge

…red-recyclerview fixed elevation to fulfill material design guidelines when both actionbar and toolbar are present

86805a0 Add 'libs/utils/' from commit '94d1dbb0f5220525759de83c60cba3e95ce95eff' cfc3ff0 use title/content params in the editor 9f26eb3 remove useless test in example 83ff559 fix appcompat and support-v4 dependencies 714eeb1 move new editor logic to a fragment 4a2f1ba back to 21.1.1 tools 279f2ee fix appcompat dependency d3985f0 new travis config ee42dda fix build for example project 66fb19b rename package name to org.wordpress.android b61040c rename package name to org.wordpress.android 4edc93f add signing to publish artifact 94d1dbb Merge branch 'release/3.7' into develop 8ff9413 fix AppLogViewerActivity when a log is message is null 7c208db Merge pull request #2264 from wordpress-mobile/issue/2222-theme-preview-title 9eb7273 new BlogUtils.getHostNameFromAccountMap function a80859d Theme live preview no longer changes the activity title 6186933 Photo viewer now uses low quality for the lo-res image 2eb9839 Simplified comments bfa7ecb Switched to quality enum which defaults to medium a2ce056 Added default quality param to photon 5a48a06 html encode log entries in AppLog.toHtml() c8a4d89 fix #103: retain menu drawer scroll position after switching activities c1e0778 Merge branch 'develop' into issue/985-make-sfactory-private fe1d125 fix build files for android studio 1.0 f7a2d48 Merge remote-tracking branch 'origin/develop' into issue/985-make-sfactory-private 72fe2b7 update support lib version for travis 0b03b71 Merge branch 'develop' of https://github.com/wordpress-mobile/WordPress-Android into feature/material-appcompat 0f5751d Merge branch 'develop' into release/3.4 b68f755 remove unused code (refresh button) cb8321b fix #985: maks sFactory private - force injection in test module faae1d3 Merge branch 'release/3.4' into issue/1982-simperium-concurrency Conflicts: WordPress/src/main/java/org/wordpress/android/models/Note.java a0982d1 Updated build.gradle to specify com.android.support:appcompat-v7:21.0.2 3a0c45e Removed unsuccessful fix for #1982. b967d59 first step at replacing PreferenceActivity by a PreferenceFragment + ActionBarActivity 92d4e15 Merge branch 'develop' into feature/material-appcompat 7c8d5ab Merge branch 'release/3.4' into develop 1e499a6 Merge branch 'hotfix/3.3.1' into release/3.4 7a4a364 Merge branch 'develop' of https://github.com/wordpress-mobile/WordPress-Android into feature/material-appcompat 5451df7 update subtrees to use build tools 21.1.1 4024637 rename PullToRefresh to SwipeToRefresh 0d8d414 remove unused viewClass in PTR constructor 2424201 fix circle spinner color style d392885 Return a copy of the JSONObject in getDiffableValue(). 106affa replace Chris Banes' PullToRefresh by the native SwipeToRefresh view 3108a36 Merge remote-tracking branch 'origin/develop' into feature/1961-add-mentions-to-commenting db25827 Merge branch 'develop' into issue/1958-round-avatars 2801610 Merge remote-tracking branch 'origin/develop' into feature/1961-add-mentions-to-commenting 6ac0248 Merge branch 'hotfix/3.3.1' into release/3.4 eb70e6f upgrade to android-gradle 0.14.0 9bc4ba6 Rounds all WPNetworkImageViews with `AVATAR` type. c2fd6c7 Initial commit adding mentions to notification comments 0a3da42 Added image spans directly instead of using Html.fromHtml(). 5b22440 Merge branch 'release/3.2' into develop 1a2a73f fix debug/release build propagation to sub projects d9eac2e Merge branch 'release/3.2' into develop 380ece6 Merge pull request #1861 from wordpress-mobile/feature/notifications-redesign c38f131 Merge pull request #1860 from wordpress-mobile/issue/1821-remove-istablet 4e92eaa Merge branch 'hotfix/3.1.2' into release/3.2 cbc7b24 fix #1821: remove DisplayUtis.isTablet() method 343771a Catch NPE in Bitmap.CreateBitmap and make sure the returned bitmap is not null c44a87a Merge branch 'release/3.2' into feature/notifications-redesign 97c557c Revert "Revert "Merge pull request #1799 from wordpress-mobile/feature/1795-reader-render-attachments"" 1cacaf2 Merge branch 'hotfix/3.1.1' into release/3.2 568782f Merge branch 'hotfix/3.1.1' into develop 96fd180 remove isTablet() check 870944d Merge branch 'release/3.2' into feature/notifications-redesign 3390393 Revert "Merge pull request #1799 from wordpress-mobile/feature/1795-reader-render-attachments" 03bbac0 Merge branch 'develop' into feature/notifications-redesign 8ec2915 Replaced String.format() with string concatenation in ReaderUtils and PhotonUtils after profiler showed String.format() to be hurting performance 1623d65 fix lint error in utils e273dd3 Merge branch 'develop' into feature/notifications-redesign 4bfc641 Removed aggressive `JSONUtil` logging f7f4556 update support-v13 library to version 19.1.0 fafcf67 Merge pull request #1781 from wordpress-mobile/issue/17760-reader-comment-full-images 1868cc5 disable refresh on the attacher 082c13f use the PTR library version 0.9.7 f21f5d3 set network refresh mode as default d262f8d remove unused code 9e592fd add a network mode in PullToRefreshHeaderTransformer to show a different message when network is disabled f85a003 move NetworkUtils to WPUtils subtree d19c080 Updated comment cabb8a7 TextView content is reset to itself to force it to correctly resize using cached image 48e4ed2 More cleanup 2426243 Cleanup WPImageGetter based on code analysis c955d26 Merge pull request #1764 from wordpress-mobile/issue/1713-send-version-code-to-mixpanel 3bc1080 Merge branch 'release/3.1' into develop f75a9e7 increment version number caa9db0 fix #1762: show blog url in the share blog spinner if the blog title is an empty string e1eecbf remove ProfilingUtils.getVersionName calls 075b989 remove unused method from ProfilingUtils b48cbda move BuildUtils to WPUtils subtree, rename BuildUtils to PackageUtils and add getPackageInfo and getVersionCode methods 44bb61e Rewrote the AppLog viewer to use a ListView+adapter 59f0bfa Merge branch 'develop' into issue/1690-track-last-seen-screen 9300d28 remove unused util file ActivityUtils b15cf64 Bump libs/utils version number. 0d89a80 generic way to track last seen activity - requires GET_TASKS permission 391276c Use the unicode version of the Horizontal ellipsis char. Restrict the visibility of some methods to private. c8dc1e8 Text view that auto adjusts text size to fit within the view.If the text size equals the minimum text size and still does not fit, append with an ellipsis. aa5b665 init utils readme 76df52f import libs/utis 449639d set defaultPublishConfig to debug - in case we had source dependencies to this module 5b1f8f1 remove gradle wrapper cd72102 Bump version number 90f9f22 Merge pull request #1 from wordpress-mobile/issue/move-ptr-to-utils c6b0ff9 showToast methods now return a Toast object 3e93210 Move pull to refresh to Utils b302b44 Move ToastUtils to Utils a0e973c document getPrimaryEmail method d68fb87 add getCircularBitmap and getRoundedEdgeBitmap from the main project merge in 80014b7 d2a76e2 avoid build failure when gradle.properties file is missing 5d683f6 use maven plugin to deploy maven artifact 70a91cb bump version number to 1.0.1 575579d gitignore tools/deploy-mvn-artifact.conf 50f2c80 maven deploying script cf85e19 ignore .idea and local.properties 7c6d4f4 add WPImageGetter and fix HtmlUtils b4baff8 remove crashlytics reference from Utils 32e98a9 merge from WordPress-Android@1a74364d0 79b7014 gitignore all build/ directories c9e6b52 Restores query separator period in `JSONUtils`. fddb5a0 Ignoring iml files 4263343 Initial commit of utils classes. 0228ac4 Fix package id name 826c265 Move java source to correct directory a528b8e Initial Project Structure git-subtree-dir: libs/editor git-subtree-split: 86805a0

Add the first iteration of Giphy Picker

Rebase

This dependency is added in order to access the activity related 'addMenuProvider(...)' API, which is not available prior to the AndroidX Activity 1.4.0 release, see below: https://developer.android.com/jetpack/androidx/releases/activity #1.4.0-alpha01 Currently, and although the project is indeed using AndroidX Activity as a transitive dependency, those point to older versions of it. Below is a breakdown per module, and in parenthesis, the version it uses: - image-editor (1.2.4) - editor (1.1.0) - WordPress (1.3.1) FYI: The activity related 'addMenuProvider(...)' API is needed because otherwise the 'Options Menu' migration can't commence. ------------------------------------------------------------------------ Release Notes: https://developer.android.com/jetpack/androidx/releases/ activity#1.5.1 ------------------------------------------------------------------------ Note that the '1.6.1' update requires libraries and applications that depend on it to compile against version 33 (Android 13) or later of the Android APIs. However, this project is currently compiled against android-31 (Android 12). Thus, until the 'compileSdkVersion' of this project gets updated to '33' updating to '1.9.0' isn't possible. ------------------------------------------------------------------------

Changed the links that are redirecting and slight changes on a sentence

Robert Collins added 2 commits April 10, 2013 10:35

Re-implementing all the menu items with the improved MenuDrawerItem c…

e25a4ae

…lass

Robert Collins added 2 commits April 10, 2013 11:30

Removing random new line

8947a6c

Removing unused import

ea6c411

beaucollins added a commit that referenced this pull request Apr 10, 2013

Merge pull request #1 from beaucollins/menu-items

286c9f1

Menu Drawer Item refactor

beaucollins merged commit 286c9f1 into wordpress-mobile:master Apr 10, 2013

beaucollins deleted the menu-items branch April 10, 2013 18:43

ShiftLeftLogical mentioned this pull request Nov 14, 2013

Should the "Status" field/spinner be updated to "Future" when changing the "publish" to a future point in time in EditPostActivity.java/View to reflect the Data? #295

Closed

roundhill mentioned this pull request Jul 23, 2014

Can't moderate Jetpack site stats in certain scenario #1654

Closed

roundhill added a commit that referenced this pull request Jul 25, 2014

Merge pull request #1 from Automattic/feature/add-ability-to-make-syn…

0b66055

…ch-calls Use Volley native listeners instead our implementation

maxme added a commit that referenced this pull request Jul 25, 2014

Merge pull request #1 from wordpress-mobile/feature/wordpress-gradle-…

0896533

…plugin Setting up project to use wordpress gradle plugin

daniloercoli added a commit that referenced this pull request Jul 25, 2014

Merge pull request #1 from wordpress-mobile/issue/move-ptr-to-utils

90f9f22

Move ptr to utils

maxme pushed a commit that referenced this pull request Feb 20, 2015

Merge pull request #1 from delftswa2014/issue/CI-build-status-#2352

b87f2fb

Added a build status image

maxme pushed a commit that referenced this pull request Mar 30, 2015

Merge pull request #1 from wordpress-mobile/develop

3ce187e

Merge

daniloercoli mentioned this pull request Jun 11, 2015

Issue/2718 site search selection #2815

Merged

nbradbury pushed a commit that referenced this pull request Mar 7, 2016

Merge pull request #1 from mzorz/issue/3827-elevation-in-reader-filte…

c51742a

…red-recyclerview fixed elevation to fulfill material design guidelines when both actionbar and toolbar are present

mzorz mentioned this pull request May 20, 2016

Feature/reader search results #4096

Merged

kwonye mentioned this pull request Jun 23, 2016

Feature/4263 replace optimizely with mixpanel #4264

Merged

mufela pushed a commit to mufela/WordPress-Android that referenced this pull request Nov 29, 2016

start build wordpress-mobile#1

eb39cf6

mufela pushed a commit to mufela/WordPress-Android that referenced this pull request Dec 5, 2016

wordpress-mobile#1.2

60c32cf

mufela pushed a commit to mufela/WordPress-Android that referenced this pull request Dec 5, 2016

wordpress-mobile#1.3

5bf268c

mufela pushed a commit to mufela/WordPress-Android that referenced this pull request Dec 5, 2016

wordpress-mobile#1.5

423ce93

mufela pushed a commit to mufela/WordPress-Android that referenced this pull request Dec 5, 2016

wordpress-mobile#1.6

4fcf97b

mufela pushed a commit to mufela/WordPress-Android that referenced this pull request Dec 5, 2016

wordpress-mobile#1.7

3c72c16

mufela pushed a commit to mufela/WordPress-Android that referenced this pull request Dec 5, 2016

wordpress-mobile#1.0

17a3892

daniloercoli mentioned this pull request Mar 23, 2017

Media Library - The "state" of items seems to be inconsistent #5483

Closed

hypest mentioned this pull request Oct 23, 2017

Issue/6600 connected email found #6754

Merged

hypest mentioned this pull request Nov 28, 2017

Update SiteCreationService from latest AutoForeground #6916

Merged

hypest mentioned this pull request Feb 9, 2018

Site creation rework: Offer a "Close" button on failure after creation #7224

Closed

This was referenced Feb 20, 2018

Site creation rework: theme loading retry when connection resumes #7247

Merged

Guard saving to smartlock on Login #7301

Merged

mzorz mentioned this pull request May 18, 2018

Moving NotificationDismissBroadcastReceiver logic to NotificationsProcessingService #7779

Merged

kwonye pushed a commit that referenced this pull request Dec 20, 2018

Merge pull request #1 from shiki/issue/8627-giphy-picker-activity

5b50ff7

Add the first iteration of Giphy Picker

thehenrybyrd mentioned this pull request Mar 8, 2019

Account Settings: better error messaging for change email flow when address is already in use #9384

Closed

malinajirka mentioned this pull request Mar 18, 2019

Crash when drawing the editor on devices running Android 8 #8828

Closed

daniloercoli mentioned this pull request Jun 6, 2019

[GB-Mobile] Fix for Permissions Denied dialog loop #10004

Merged

malinajirka mentioned this pull request Jun 7, 2019

Fix issue where two identical drafts were created #10009

Merged

diouldebalde referenced this pull request Jul 12, 2019

Update to release-toolkit 0.5.0

48833d0

jkmassel mentioned this pull request Oct 25, 2019

Implement Encrypted Logging for WPAndroid #10698

Closed

zwarm mentioned this pull request Feb 10, 2020

Issue/11119 search in set parent page #11269

Merged

3 tasks

hypest mentioned this pull request May 15, 2020

Gutenberg/no jitpack updates to gutenberg 1.28 branch #11921

Merged

3 tasks

planarvoid pushed a commit that referenced this pull request Oct 12, 2020

Merge pull request #1 from wordpress-mobile/develop

330e28c

Rebase

jkmassel pushed a commit that referenced this pull request Jul 9, 2024

Merge pull request #1 from josevarghese/patch-2

3fc025f

Changed the links that are redirecting and slight changes on a sentence

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Menu Drawer Item refactor #1

Menu Drawer Item refactor #1

Menu Drawer Item refactor #1

Menu Drawer Item refactor #1

Conversation