[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site creation rework: Offer a "Close" button on failure after creation #7224

Closed
wants to merge 1 commit into from
Closed

Site creation rework: Offer a "Close" button on failure after creation #7224

wants to merge 1 commit into from

Conversation

hypest
Copy link
Contributor
@hypest hypest commented Feb 9, 2018

Fixes #7221

Shows a "Close" button when the site-creation process finishes but the new site has been created remotely. If it hasn't, a "Back" button is displayed.

To test #1:

  • With the app logged in to wpcom, go to the site picker and start creating a new site. Bring the wizard up to step 4 (subdomain selection) but wait.
  • Turn connectivity off
  • Push the "CREATE SITE" button
  • The "Creating" screen comes up, it informs that something went wrong and it displays a "Back" button on the toolbar
  • Tap the "Back" button and notice the wizard returning to step 4

To test #2:

  • With the app logged in to wpcom, go to the site picker and start creating a new site. Bring the wizard up to step 4 (subdomain selection).
  • Be ready to turn connectivity off after the "Creating" screen comes up
  • Push the "CREATE SITE" button and wait for the process to reach the "Retrieving site information" step
  • Turn connectivity off
  • The app informs that something went wrong and it displays a "X" button on the toolbar
  • Tap the "X" button and notice the app returning directly to the site picker

@hypest hypest mentioned this pull request Feb 9, 2018
Closed
13 tasks
@hypest hypest requested a review from theck13 February 17, 2018 22:29
theck13
theck13 suggested changes Feb 20, 2018
View reviewed changes
Copy link
Contributor
@theck13 theck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but there are a few conflicts to resolve before merging.

@hypest
Copy link
Contributor Author
hypest commented Feb 20, 2018

Closing this PR in favor of #7247 as it turns out the commit included here already got reviewed in #7247. Will copy the testplans there as well.

@hypest hypest closed this Feb 20, 2018
@hypest hypest deleted the issue/7221-site-creation-close-button branch February 20, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theck13 theck13 theck13 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hypest @theck13