[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove is_clang_16 #3616

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Remove is_clang_16 #3616

merged 1 commit into from
Jun 28, 2024

Conversation

niranjanyardi
Copy link
Contributor
@niranjanyardi niranjanyardi commented Jun 21, 2024 •
edited
Loading

b/323184809

is_clang_16 is a temporary variable from a year ago which needs to be cleaned up as we have moved on to clang17.

Replace is_clang_16 with is_clang && current_os != "android"
as android uses clang version 14

@niranjanyardi niranjanyardi force-pushed the remove_clang_16 branch 4 times, most recently from 865c976 to 2516b53 Compare June 21, 2024 21:24
@codecov Codecov
Copy link
codecov bot commented Jun 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.20%. Comparing base (84bd543) to head (2516b53).
Report is 46 commits behind head on main.

❗ Current head 2516b53 differs from pull request most recent head a92cd67

Please upload reports for the commit a92cd67 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3616      +/-   ##
==========================================
- Coverage   58.74%   58.20%   -0.54%     
==========================================
  Files        1781     1779       -2     
  Lines       85283    86040     +757     
==========================================
- Hits        50099    50081      -18     
- Misses      35184    35959     +775

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niranjanyardi niranjanyardi force-pushed the remove_clang_16 branch 3 times, most recently from 586796d to e5fcd07 Compare June 24, 2024 21:08
@niranjanyardi
Copy link
Contributor Author
niranjanyardi commented Jun 24, 2024 •
edited
Loading

Corresponding internal change is here: go/lbreview/285820

Internal builders seem to pass the GN step as expected. PS5 fails on an unrelated change

@niranjanyardi niranjanyardi marked this pull request as ready for review June 24, 2024 22:37
kaidokert
kaidokert approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member
@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks okay to put in. But you may want to double-check if all these places actually still do require this current_os != android condition at all, especially in upstream code.

I know it will require a bit of trial and error back to back builds for Android, but it should be fairly quick.

@andrewsavage1
Copy link
Contributor
andrewsavage1 commented Jun 25, 2024 •
edited by niranjanyardi
Loading

What's the goal with this change? Why do we want to remove is_clang_16?

@niranjanyardi
Remove is_clang_16
a92cd67 
Change-Id: Id9bfd61837354f84b202bcd2d6b59c4d5401194a
@niranjanyardi
Copy link
Contributor Author

Overall looks okay to put in. But you may want to double-check if all these places actually still do require this current_os != android condition at all, especially in upstream code.

I know it will require a bit of trial and error back to back builds for Android, but it should be fairly quick.

Removed !is_android in some places . remaining errors documented here: https://b.corp.google.com/issues/323184809#comment23

@niranjanyardi
Copy link
Contributor Author
niranjanyardi commented Jun 25, 2024 •
edited
Loading

What's the goal with this change? Why do we want to remove is_clang_16?

that variable was a placeholder when we moved to clang 16 a year ago, we have since updated to m114's clang 17

@niranjanyardi niranjanyardi merged commit bc5acc2 into youtube:main Jun 28, 2024
325 of 329 checks passed
@niranjanyardi niranjanyardi deleted the remove_clang_16 branch June 28, 2024 17:55
@niranjanyardi niranjanyardi added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Jun 28, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jun 28, 2024
@niranjanyardi @anonymous1-me
Remove is_clang_16 (#3616)
1913adb 
b/323184809

is_clang_16 is a temporary variable from a year ago which needs to be
cleaned up as we have moved on to clang17.

Replace `is_clang_16 `with `is_clang && current_os != "android" `
as android uses  [clang version 14 ](go/auditmodularplatforms)

(cherry picked from commit bc5acc2)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Jun 28, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y4vor y4vor y4vor approved these changes

@kaidokert kaidokert kaidokert approved these changes

@andrewsavage1 andrewsavage1 andrewsavage1 approved these changes

Assignees
No one assigned
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Milestone
No milestone
4 participants
@niranjanyardi @andrewsavage1 @y4vor @kaidokert