Cherry pick PR #3616: Remove is_clang_16 #3716
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b/323184809 is_clang_16 is a temporary variable from a year ago which needs to be cleaned up as we have moved on to clang17. Replace `is_clang_16 `with `is_clang && current_os != "android" ` as android uses [clang version 14 ](go/auditmodularplatforms) (cherry picked from commit bc5acc2)
|
Important There were merge conflicts while cherry picking! Check out cherry-pick-25.lts.1+-3616 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/9716758016 for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #3616
b/323184809
is_clang_16 is a temporary variable from a year ago which needs to be cleaned up as we have moved on to clang17.
Replace
is_clang_16withis_clang && current_os != "android"as android uses clang version 14