[go: nahoru, domu]

Page MenuHomePhabricator

[Config] Deploy dark mode to all users in tier 1 wikis on the Minerva skin
Closed, ResolvedPublic2 Estimated Story Points

Description

NOTE: We are deploying with the following known bugs T368789, T368483 (if unable to backport). Talk pages will not get dark mode in the initial release.

Deployment date

Jul 1, 2024 and Jul 2, 2024

Background

  • This ticket will track the deployment and any blockers of dark mode for logged-out users to the Minerva skin

User story

  • As a mobile reader, I want the ability to read in dark mode so that I can read easily in low-light settings

Requirements

  • The color section should be available on the appearance menu
  • The default color should be "light" for logged in users
  • The default color should be "light" for logged out users
  • Selecting dark mode should change the page to appear in dark mode
  • If the page is not available in dark mode, users will not be able to switch to dark mode and a notice will be available
  • The change will only be deployed on wikis that are flagged as ready by T367310.
  • Ensure Central Notice banner is ready to go prior to deploying
  • Deploy search page dark mode

Refined Requirement

  • Deploy dark mode to all users on tier 1 wikis using the Minerva skin, ensuring it is enabled by default and functions correctly across all relevant pages.

BDD

  • Feature: Dark Mode Deployment on Tier 1 Wikis

Scenario: Enable dark mode for all users on tier 1 wikis using the Minerva skin

Given a user on a tier 1 wiki using the Minerva skin
When they visit any page
Then dark mode should be enabled by default
And the page should display correctly in dark mode

Test Steps

  • Test Case 1: Verify Dark Mode is Enabled by Default
  1. Open a tier 1 wiki (enwiki, gawiki, kabwiki, zhwiki in an incognito window) on the Minerva skin.
  2. Navigate to various pages (e.g., Main Page, article pages, Special pages).
  3. ✅❓❌⬜ AC1: Confirm dark mode is enabled by default on all pages.

Design

  • Add mockups and design requirements

Acceptance criteria

  • All subtasks are complete
  • All requirements are complete
  • All Communication criteria is complete
  • Pre deploy - check VisualEditor in en.wikipedia.org (Thursday 27th) and identify backports that are needed
  • Check if anything is needed for T366296 prior to deploy
  • A fix for T368483 is backported
  • Deploy to the following list of wikis: https://docs.google.com/spreadsheets/d/10HDDetQVC9DijEWITtzGoP-Nv_VrqvXdPskhtAsw9M0/edit?gid=0#gid=0
    • Deploy to logged in users on 1st with any necessary backports (banwiki, bjnwiki, enwiki, frwiki, gawiki, kabwiki, kowiki, pawiki, tumwiki, zhwiki)
    • Deploy to logged out users on 2nd with any necessary backports ( enwiki, gawiki, kabwiki, zhwiki)

Communication criteria - does this need an announcement or discussion?

  • Community is informed across wikis and any necessary questions and concerns are addressed

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

To mitigate issues we will deploy to logged in users first.
For emergencies we should be able to roll back given the default is day mode without any caching implications.

This task was created by Version 1.0.0 of the Web team task template using phabulous

QA Results - PROD

ACStatusDetails
1T367151#9957296

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdlrobson subscribed.

@ovasileva

  1. Are history pages a blocker?

if T367438 is a blocker, I assume that means dark mode history support is a blocker - so T366371 should be added as a subtask?

  1. Is Homepage a blocker?

Not listed in the blockers here yet but it's presented to lots of new users: https://phabricator.wikimedia.org/T357699

  1. Is search a blocker?

Not listed in the blockers but accessible if I click "search within pages" (https://phabricator.wikimedia.org/T367375)

  1. Is Special:Notifications a blocker?

This shows when you right click the notification icon, or click "all notifications" in the overlay. Tracked in T358405 but not in sprint.

  1. Are the defaults correct?

I recall Justin saying he'd feel more comfortable with day as the default everywhere. Do we need to adjust the acceptance criteria?

  1. When do we want to deploy this?

Rough estimate: with all existing subtasks, I think this could be scheduled for 27th June (or sooner if you are okay with shipping without the history page in dark mode)

@ovasileva

  1. Are history pages a blocker?

Not for initial Minerva deploy

if T367438 is a blocker, I assume that means dark mode history support is a blocker - so T366371 should be added as a subtask?

  1. Is Homepage a blocker?

Not listed in the blockers here yet but it's presented to lots of new users: https://phabricator.wikimedia.org/T357699

Not for initial Minerva deploy

  1. Is search a blocker?

Not listed in the blockers but accessible if I click "search within pages" (https://phabricator.wikimedia.org/T367375)

Yes

  1. Is Special:Notifications a blocker?

This shows when you right click the notification icon, or click "all notifications" in the overlay. Tracked in T358405 but not in sprint.

No, but it is a blocker for desktop deploy. Pulling into sprint.

  1. Are the defaults correct?

I recall Justin saying he'd feel more comfortable with day as the default everywhere. Do we need to adjust the acceptance criteria?

Day is the correct default

  1. When do we want to deploy this?

Deployment date Jul 1

Rough estimate: with all existing subtasks, I think this could be scheduled for 27th June (or sooner if you are okay with shipping without the history page in dark mode)

Change #1050084 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Mobile: Enable dark mode for all tier 1 wikis (logged in)

https://gerrit.wikimedia.org/r/1050084

Change #1050085 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Mobile: Enable dark mode for all users for tier 1 wikis

https://gerrit.wikimedia.org/r/1050085

Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)

Patches are ready to go for Monday and Tuesday but we still need to decide if T368483 is a blocker and needs backporting.

Jdlrobson renamed this task from [Config] Deploy dark mode to all users on the Minerva skin to [Config] Deploy dark mode to all users in tier 1 wikis on the Minerva skin .Jun 28 2024, 9:10 PM

Change #1050084 merged by jenkins-bot:

[operations/mediawiki-config@master] [July 1st] Mobile: Enable dark mode for all tier 1 wikis (logged in)

https://gerrit.wikimedia.org/r/1050084

Mentioned in SAL (#wikimedia-operations) [2024-07-01T20:03:12Z] <cjming@deploy1002> Started scap sync-world: Backport for [[gerrit:1050084|[July 1st] Mobile: Enable dark mode for all tier 1 wikis (logged in) (T367151)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-01T20:23:41Z] <cjming@deploy1002> jdlrobson, cjming: Backport for [[gerrit:1050084|[July 1st] Mobile: Enable dark mode for all tier 1 wikis (logged in) (T367151)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-07-01T20:26:08Z] <cjming@deploy1002> Started scap sync-world: Backport for [[gerrit:1050084|[July 1st] Mobile: Enable dark mode for all tier 1 wikis (logged in) (T367151)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-01T20:28:43Z] <cjming@deploy1002> jdlrobson, cjming: Backport for [[gerrit:1050084|[July 1st] Mobile: Enable dark mode for all tier 1 wikis (logged in) (T367151)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-07-01T20:31:44Z] <cjming@deploy1002> Started scap sync-world: Backport for [[gerrit:1050084|[July 1st] Mobile: Enable dark mode for all tier 1 wikis (logged in) (T367151)]], [[gerrit:1051184|Change color of notification icon in dark-mode (T368120)]], [[gerrit:1051186|Do not invert images that have been tagged with no invert classes (T368483)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-01T20:34:29Z] <cjming@deploy1002> cjming, jdlrobson: Backport for [[gerrit:1050084|[July 1st] Mobile: Enable dark mode for all tier 1 wikis (logged in) (T367151)]], [[gerrit:1051184|Change color of notification icon in dark-mode (T368120)]], [[gerrit:1051186|Do not invert images that have been tagged with no invert classes (T368483)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-07-01T20:42:24Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:1050084|[July 1st] Mobile: Enable dark mode for all tier 1 wikis (logged in) (T367151)]], [[gerrit:1051184|Change color of notification icon in dark-mode (T368120)]], [[gerrit:1051186|Do not invert images that have been tagged with no invert classes (T368483)]] (duration: 10m 39s)

It is impossible to actually open the Google spreadsheets link if you don’t have access. Please duplicate its contents somewhere public, e.g. Phabricator, the software we use for bug tracking.

Done.

@ovasileva I was a bit dubious about some of the "Stage 1" wikis and re-ran the color contrast checker. I realize now our testing was flawed - by testing only on desktop we're missing a bunch of issues on mobile - for example the table Candidatures dans chaque circonscription on https://fr.m.wikipedia.org/wiki/Ensemble_pour_la_République_(France)?vectornightmode=1&minervanightmode=1 is collapsed on desktop but not on mobile.

I would therefore propose we remove the following wikis before the deploy tomorrow as they don't meet our criteria by large margins on mobile (only desktop!):
Calculations here: https://docs.google.com/spreadsheets/d/12DyzW2VhNTNuH4kww2anTItJL4FWAM6bU1GnvCcW_ZE/edit?gid=0#gid=0

Done.

@ovasileva I was a bit dubious about some of the "Stage 1" wikis and re-ran the color contrast checker. I realize now our testing was flawed - by testing only on desktop we're missing a bunch of issues on mobile - for example the table Candidatures dans chaque circonscription on https://fr.m.wikipedia.org/wiki/Ensemble_pour_la_République_(France)?vectornightmode=1&minervanightmode=1 is collapsed on desktop but not on mobile.

I would therefore propose we remove the following wikis before the deploy tomorrow as they don't meet our criteria by large margins on mobile (only desktop!):
Calculations here: https://docs.google.com/spreadsheets/d/12DyzW2VhNTNuH4kww2anTItJL4FWAM6bU1GnvCcW_ZE/edit?gid=0#gid=0

That sounds good to me.

We've reduced the deploy list to English, Chinese, Gaelic and Sierra Leonean Creole languages for now. Kim will take care of the deployment for anonymous users today.

Change #1050085 merged by jenkins-bot:

[operations/mediawiki-config@master] [July 2nd] Mobile: Enable dark mode for all users for tier 1 wikis

https://gerrit.wikimedia.org/r/1050085

Mentioned in SAL (#wikimedia-operations) [2024-07-02T20:04:34Z] <urbanecm@deploy1002> Started scap sync-world: Backport for [[gerrit:1050085|[July 2nd] Mobile: Enable dark mode for all users for tier 1 wikis (T367151)]], [[gerrit:1048138|Remove unused Linter configs (T343292)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-02T20:07:21Z] <urbanecm@deploy1002> jdlrobson, arlolra, urbanecm: Backport for [[gerrit:1050085|[July 2nd] Mobile: Enable dark mode for all users for tier 1 wikis (T367151)]], [[gerrit:1048138|Remove unused Linter configs (T343292)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-07-02T20:21:06Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:1050085|[July 2nd] Mobile: Enable dark mode for all users for tier 1 wikis (T367151)]], [[gerrit:1048138|Remove unused Linter configs (T343292)]] (duration: 16m 31s)

Jdlrobson updated the task description. (Show Details)

This was checked in more detail but gave a quick video run-through on dark mode due to the allowed sizes.

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Dark Mode is Enabled by Default

  1. Open a tier 1 wiki (enwiki, gawiki, kabwiki, zhwiki in an incognito window) on the Minerva skin.
  2. Navigate to various pages (e.g., Main Page, article pages, Special pages).
  3. ✅❓❌⬜ AC1: Confirm dark mode is enabled by default on all pages.
Enwiki
Gawiki
Kawiki
Zhwiki
GMikesell-WMF assigned this task to ovasileva.
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF subscribed.
ovasileva updated the task description. (Show Details)