Regression: Global invert broke VisualEditor "Add a link" workflow
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Wed, Jun 26, 12:19 AM

Description

NOTE: This is a regression caused by T365764. Steps to replicate the issue (include links if applicable):

Visit https://en.wikipedia.beta.wmflabs.org/w/index.php?title=T352930&action=edit
Click edit
Click the link icon to add a link
Type T

What happens?:

Screenshot 2024-06-25 at 5.19.09 PM.png (901×410 px, 87 KB)

What should have happened instead?:
The results should not be inverted.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

AC	Status	Details
1	✅	T368483#9951071

Details

Other Assignee: Jdlrobson

Subject	Repo	Branch	Lines +/-
Do not invert images that have been tagged with no invert classes	mediawiki/skins/MinervaNeue	wmf/1.43.0-wmf.11	+2 -2
Do not invert images that have been tagged with no invert classes	mediawiki/skins/MinervaNeue	master	+2 -2
TitleOptionWidget: Unconditionally add mw-no-invert class	mediawiki/core	master	+2 -1
Add mw-no-invert and oo-ui-image-invert to OOUI icon exclusion list	mediawiki/skins/Vector	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	ovasileva	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Open	ovasileva	T341632 [EPIC] Palette customizations and dark mode
Open	None	T367150 Deploy dark mode to logged-out users in tier 1 and 2 wikis on the Vector2022 and Minerva skin
Resolved	ovasileva	T368483 Regression: Global invert broke VisualEditor "Add a link" workflow

Event Timeline

Jdlrobson created this task.Wed, Jun 26, 12:19 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Jun 26, 12:19 AM

I don't know how to fix this without us removing the global icon selector.
This should be a blocker for rolling out dark mode to desktop.

Jdlrobson added a parent task: T367150: Deploy dark mode to logged-out users in tier 1 and 2 wikis on the Vector2022 and Minerva skin.Wed, Jun 26, 12:28 AM

Jdlrobson mentioned this in T367813: [QA only] Media overlay, citation, link and template and save changes overlay close icon/search icon invisible.

Since T345281 all non-inverting images are marked with mw-no-invert, or cdx-no-invert.

Change #1049979 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Add oo-ui-image-invert to icon exclusion list

https://gerrit.wikimedia.org/r/1049979

gerritbot added a project: Patch-For-Review.Wed, Jun 26, 3:52 PM

Change #1049983 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] TitleOptionWidget: Unconditionally add mw-no-invert class

https://gerrit.wikimedia.org/r/1049983

Change #1049979 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add mw-no-invert and oo-ui-image-invert to OOUI icon exclusion list

https://gerrit.wikimedia.org/r/1049979

We may need to backport this on Monday, so assigning to myself.

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Thu, Jun 27, 5:00 PM

ovasileva set the point value for this task to 2.Thu, Jun 27, 5:27 PM

ovasileva moved this task from Needs analysis to Blocked on Others on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.

Waiting for guidance from Ed on which class to add here: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1049983
I've noted it in T368483 as needing a backport.

I am confused what's left to do in this task. The current appearance looks alright to me.

Can you say what's the expected appearance?

ppelberg added a project: Editing-team (Kanban Board).Mon, Jul 1, 4:26 PM

ppelberg moved this task from Incoming to QA on the Editing-team (Kanban Board) board.

ppelberg subscribed.

In T368483#9940467, @matmarex wrote:

I am confused what's left to do in this task. The current appearance looks alright to me.

Can you say what's the expected appearance?

Do you have anything installed that might be modifying e.g. the dark mode gadget?
I am still seeing this issue:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Conflict-title-0.5273683049984046-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n?minervanightmode=1#/editor/0

Screenshot 2024-07-01 at 9.41.08 AM.png (749×1 px, 105 KB)

Having checked, like Jon I'm still seeing the images as inverted. That said, I wonder if there's something wrong with Beta's caching of the compiled less (or with that patch to Vector) -- the icons do have mw-no-invert on them.

ppelberg moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Mon, Jul 1, 5:11 PM

I don't have anything unusual enabled, as far as I know. I actually took that screenshot while logged out, on https://en.wikipedia.beta.wmflabs.org/w/index.php?title=T352930&veaction=edit, but I can't reproduce while logged in either.

Oh – it's broken on mobile, but not on desktop.

ovasileva edited projects, added Web-Team-Backlog (FY2024-25 Q1 Sprint 1); removed Web-Team-Backlog (FY2023-24 Q4 Sprint 6).Mon, Jul 1, 5:43 PM

ovasileva moved this task from Needs analysis to Blocked on Others on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

I'm not particularly familiar with how dark mode was implemented, so: was the expectation that the earlier Vector patch adding new classes to OOUIIconSelectors should have fixed this in mobile (i.e. in MinervaNeue)?

@DLynch weird.. I can confirm the mw-no-invert class is present (I could have sworn it wasn't when we started this ticket! Did something change recently) and this needs a patch in Minerva. Working on that now.

Change #1051182 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Do not invert images that have been tagged with no invert classes

https://gerrit.wikimedia.org/r/1051182

Change #1049983 abandoned by Jdlrobson:

[mediawiki/core@master] TitleOptionWidget: Unconditionally add mw-no-invert class

Reason:

It seems this is working as expected. Misunderstanding on our part. Posted https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1051182

https://gerrit.wikimedia.org/r/1049983

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.Mon, Jul 1, 6:10 PM

Change #1051182 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Do not invert images that have been tagged with no invert classes

https://gerrit.wikimedia.org/r/1051182

Change #1051186 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@wmf/1.43.0-wmf.11] Do not invert images that have been tagged with no invert classes

https://gerrit.wikimedia.org/r/1051186

Looks fixed to me on beta mobile following that patch (and some fairly aggressive cache-clearing):

Change #1051186 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.43.0-wmf.11] Do not invert images that have been tagged with no invert classes

https://gerrit.wikimedia.org/r/1051186

Maintenance_bot removed a project: Patch-For-Review.Mon, Jul 1, 8:31 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-01T20:31:44Z] <cjming@deploy1002> Started scap sync-world: Backport for [[gerrit:1050084|[July 1st] Mobile: Enable dark mode for all tier 1 wikis (logged in) (T367151)]], [[gerrit:1051184|Change color of notification icon in dark-mode (T368120)]], [[gerrit:1051186|Do not invert images that have been tagged with no invert classes (T368483)]]

Stashbot mentioned this in T368120: [Short term fix] Notification icon not same color as other icons.Mon, Jul 1, 8:31 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-01T20:34:29Z] <cjming@deploy1002> cjming, jdlrobson: Backport for [[gerrit:1050084|[July 1st] Mobile: Enable dark mode for all tier 1 wikis (logged in) (T367151)]], [[gerrit:1051184|Change color of notification icon in dark-mode (T368120)]], [[gerrit:1051186|Do not invert images that have been tagged with no invert classes (T368483)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Jdlrobson reassigned this task from Jdlrobson to GMikesell-WMF.Mon, Jul 1, 8:40 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

Mentioned in SAL (#wikimedia-operations) [2024-07-01T20:42:24Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:1050084|[July 1st] Mobile: Enable dark mode for all tier 1 wikis (logged in) (T367151)]], [[gerrit:1051184|Change color of notification icon in dark-mode (T368120)]], [[gerrit:1051186|Do not invert images that have been tagged with no invert classes (T368483)]] (duration: 10m 39s)

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.11; 2024-06-25); removed MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Mon, Jul 1, 9:00 PM

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Visit https://en.wikipedia.beta.wmflabs.org/w/index.php?title=T352930&action=edit
Click edit
Click the link icon to add a link
Type T or S

T	S

GMikesell-WMF removed GMikesell-WMF as the assignee of this task.Wed, Jul 3, 6:04 PM

GMikesell-WMF assigned this task to ovasileva.

GMikesell-WMF updated the task description. (Show Details)

GMikesell-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

GMikesell-WMF subscribed.

GMikesell-WMF mentioned this in T367779: Verify 1.43.0-wmf.11 deployment.Wed, Jul 3, 9:37 PM

Looks good! Resolving.

	F56132361: Screenshot 2024-07-01 at 9.41.08 AM.png
	Mon, Jul 1, 4:41 PM

	F55882848: Screenshot 2024-06-25 at 5.19.09 PM.png
	Wed, Jun 26, 12:19 AM

	F56138179: image.png
	Mon, Jul 1, 7:06 PM

	F56129467: image.png
	Mon, Jul 1, 3:45 PM

Regression: Global invert broke VisualEditor "Add a link" workflowClosed, ResolvedPublic2 Estimated Story PointsActions