[go: nahoru, domu]
Page MenuHomePhabricator
Create Task
Maniphest T368543

Error: Call to a member function getPageAsLinkTarget() on null
Open, Needs TriagePublicPRODUCTION ERROR
Actions

Description

This is a series of three issues, which all seem related: a warning, a notice, and finally an error.

Error
The warning on line 102
PHP Warning: explode() expects parameter 2 to be string, object given
The notice on line 107
PHP Notice: Trying to access array offset on value of type null

And then the full error:

normalized_message
[{reqId}] {exception_url}   Error: Call to a member function getPageAsLinkTarget() on null
exception.trace
from /srv/mediawiki/php-1.43.0-wmf.10/extensions/EventLogging/includes/JsonSchemaContent.php(109)
#0 /srv/mediawiki/php-1.43.0-wmf.10/includes/content/JsonContent.php(112): MediaWiki\Extension\EventLogging\JsonSchemaContent->objectRow(string, stdClass)
#1 /srv/mediawiki/php-1.43.0-wmf.10/includes/content/JsonContent.php(186): MediaWiki\Content\JsonContent->objectTable(stdClass)
#2 /srv/mediawiki/php-1.43.0-wmf.10/includes/content/JsonContent.php(137): MediaWiki\Content\JsonContent->valueCell(stdClass)
#3 /srv/mediawiki/php-1.43.0-wmf.10/extensions/EventLogging/includes/JsonSchemaContent.php(117): MediaWiki\Content\JsonContent->objectRow(string, stdClass)
#4 /srv/mediawiki/php-1.43.0-wmf.10/includes/content/JsonContent.php(112): MediaWiki\Extension\EventLogging\JsonSchemaContent->objectRow(string, stdClass)
#5 /srv/mediawiki/php-1.43.0-wmf.10/includes/content/JsonContent.php(83): MediaWiki\Content\JsonContent->objectTable(stdClass)
#6 /srv/mediawiki/php-1.43.0-wmf.10/includes/content/JsonContentHandler.php(127): MediaWiki\Content\JsonContent->rootValueTable(stdClass)
#7 /srv/mediawiki/php-1.43.0-wmf.10/extensions/EventLogging/includes/JsonSchemaContentHandler.php(55): MediaWiki\Content\JsonContentHandler->fillParserOutput(MediaWiki\Extension\EventLogging\JsonSchemaContent, MediaWiki\Content\Renderer\ContentParseParams, MediaWiki\Parser\ParserOutput)
#8 /srv/mediawiki/php-1.43.0-wmf.10/includes/content/ContentHandler.php(1674): MediaWiki\Extension\EventLogging\JsonSchemaContentHandler->fillParserOutput(MediaWiki\Extension\EventLogging\JsonSchemaContent, MediaWiki\Content\Renderer\ContentParseParams, MediaWiki\Parser\ParserOutput)
#9 /srv/mediawiki/php-1.43.0-wmf.10/includes/content/Renderer/ContentRenderer.php(67): ContentHandler->getParserOutput(MediaWiki\Extension\EventLogging\JsonSchemaContent, MediaWiki\Content\Renderer\ContentParseParams)
#10 /srv/mediawiki/php-1.43.0-wmf.10/includes/Revision/RenderedRevision.php(260): MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(MediaWiki\Extension\EventLogging\JsonSchemaContent, MediaWiki\Title\Title, MediaWiki\Revision\RevisionStoreRecord, ParserOptions, boolean)
#11 /srv/mediawiki/php-1.43.0-wmf.10/includes/Revision/RenderedRevision.php(232): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(MediaWiki\Extension\EventLogging\JsonSchemaContent, boolean)
#12 /srv/mediawiki/php-1.43.0-wmf.10/includes/Revision/RevisionRenderer.php(226): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#13 /srv/mediawiki/php-1.43.0-wmf.10/includes/Revision/RevisionRenderer.php(164): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, ParserOptions, array)
#14 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#15 /srv/mediawiki/php-1.43.0-wmf.10/includes/Revision/RenderedRevision.php(199): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#16 /srv/mediawiki/php-1.43.0-wmf.10/includes/page/ParserOutputAccess.php(381): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#17 /srv/mediawiki/php-1.43.0-wmf.10/includes/page/ParserOutputAccess.php(332): MediaWiki\Page\ParserOutputAccess->renderRevision(WikiPage, ParserOptions, MediaWiki\Revision\RevisionStoreRecord, integer)
#18 /srv/mediawiki/php-1.43.0-wmf.10/includes/content/ContentHandler.php(1451): MediaWiki\Page\ParserOutputAccess->getParserOutput(WikiPage, ParserOptions, MediaWiki\Revision\RevisionStoreRecord, integer)
#19 /srv/mediawiki/php-1.43.0-wmf.10/extensions/CirrusSearch/includes/BuildDocument/ParserOutputPageProperties.php(86): ContentHandler->getParserOutputForIndexing(WikiPage, NULL, MediaWiki\Revision\RevisionStoreRecord)
#20 /srv/mediawiki/php-1.43.0-wmf.10/includes/libs/objectcache/wancache/WANObjectCache.php(1726): CirrusSearch\BuildDocument\ParserOutputPageProperties->CirrusSearch\BuildDocument\{closure}(boolean, integer, array, NULL, array)
#21 /srv/mediawiki/php-1.43.0-wmf.10/includes/libs/objectcache/wancache/WANObjectCache.php(1556): WANObjectCache->fetchOrRegenerate(string, integer, Closure, array, array)
#22 /srv/mediawiki/php-1.43.0-wmf.10/extensions/CirrusSearch/includes/BuildDocument/ParserOutputPageProperties.php(95): WANObjectCache->getWithSetCallback(string, integer, Closure)
#23 /srv/mediawiki/php-1.43.0-wmf.10/extensions/CirrusSearch/includes/BuildDocument/ParserOutputPageProperties.php(51): CirrusSearch\BuildDocument\ParserOutputPageProperties->finalizeReal(Elastica\Document, WikiPage, CirrusSearch\CirrusSearch, MediaWiki\Revision\RevisionStoreRecord)
#24 /srv/mediawiki/php-1.43.0-wmf.10/extensions/CirrusSearch/includes/BuildDocument/BuildDocument.php(196): CirrusSearch\BuildDocument\ParserOutputPageProperties->finalize(Elastica\Document, MediaWiki\Title\Title, MediaWiki\Revision\RevisionStoreRecord)
#25 /srv/mediawiki/php-1.43.0-wmf.10/extensions/CirrusSearch/includes/Api/QueryBuildDocument.php(106): CirrusSearch\BuildDocument\BuildDocument->finalize(Elastica\Document, boolean, MediaWiki\Revision\RevisionStoreRecord)
#26 /srv/mediawiki/php-1.43.0-wmf.10/includes/api/ApiQuery.php(706): CirrusSearch\Api\QueryBuildDocument->execute()
#27 /srv/mediawiki/php-1.43.0-wmf.10/includes/api/ApiMain.php(1952): ApiQuery->execute()
#28 /srv/mediawiki/php-1.43.0-wmf.10/includes/api/ApiMain.php(928): ApiMain->executeAction()
#29 /srv/mediawiki/php-1.43.0-wmf.10/includes/api/ApiMain.php(899): ApiMain->executeActionWithErrorHandling()
#30 /srv/mediawiki/php-1.43.0-wmf.10/includes/api/ApiEntryPoint.php(158): ApiMain->execute()
#31 /srv/mediawiki/php-1.43.0-wmf.10/includes/MediaWikiEntryPoint.php(200): MediaWiki\Api\ApiEntryPoint->execute()
#32 /srv/mediawiki/php-1.43.0-wmf.10/api.php(44): MediaWiki\MediaWikiEntryPoint->run()
#33 /srv/mediawiki/w/api.php(3): require(string)
#34 {main}
Impact

Logspam, invalid API responses, and (I think) failure to index some content? (Judging by prop=cirrusbuilddoc.)

Notes

Details

Request URL
https://meta.wikimedia.org/w/api.php?action=query&format=json&cbbuilders=content%7Clinks&prop=cirrusbuilddoc&formatversion=2&format=json&revids=27016577

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Wed, Jun 26, 2:43 PM
Restricted Application added a project: Data-Engineering. · View Herald TranscriptWed, Jun 26, 2:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lucas_Werkmeister_WMDE added a comment.Wed, Jun 26, 2:45 PM

I’m not really sure how this code could ever have worked:

includes/JsonSchemaContent.php
	public function objectRow( $key, $val ) {
		if ( $key === '$ref' ) {
			$valParts = explode( '/', $val, 2 );
			if ( !isset( $valParts[1] ) ) {
				// Don't store or inject service objects in Content objects
				// as that breaks serialization (T286610).
				$services = MediaWikiServices::getInstance();
				$revId = (int)$valParts[1];
				$revRecord = $services->getRevisionLookup()->getRevisionById( $revId );
				$title = $revRecord->getPageAsLinkTarget();

We’ve already checked that $valParts[1] isn’t set, but then we still cast it to an int, and try to load a revision record from that ID? Is the if condition just flipped from what it should be?

I also don’t see any recent changes to the code, which is confusing.

Ottomata added a project: Data Products.Wed, Jun 26, 3:57 PM
Ottomata subscribed.

FWIW, we are SO CLOSE to not needing EventLogging\JsonSchemaContent for WMF purposes. Once T353817 is done, we can do T238230, which will remove WMF usage of EventLogging on wiki JSONSchemas.

Ottomata added projects: Discovery-Search, CirrusSearch.Wed, Jun 26, 3:58 PM

Adding Search since this seems to be triggered from CirrusSearch?

Gehel moved this task from needs triage to Current work on the Discovery-Search board.Mon, Jul 1, 3:21 PM
Gehel edited projects, added Discovery-Search (Current work); removed Discovery-Search.
Gehel moved this task from Incoming to Blocked/Waiting on the Discovery-Search (Current work) board.
dcausse subscribed.Thu, Jul 4, 8:25 AM
In T368543#9926759, @Lucas_Werkmeister_WMDE wrote:

We’ve already checked that $valParts[1] isn’t set, but then we still cast it to an int, and try to load a revision record from that ID? Is the if condition just flipped from what it should be?

yes I don't see how this could ever have worked, it is possible that this problem was somehow hidden by other problems like T286610 that got fixed recently?

Gehel edited projects, added Metrics Platform Backlog, Discovery-Search; removed Discovery-Search (Current work).Mon, Jul 8, 3:17 PM
Gehel removed a project: Discovery-Search.
Gehel subscribed.

This is about event logging, removing Discovery-Search

phuedx subscribed.Tue, Jul 16, 9:39 AM

The problem appears to have been highlighted by this edit to the Schema schema.

phuedx added a comment.Tue, Jul 16, 10:02 AM
In T368543#9926759, @Lucas_Werkmeister_WMDE wrote:

I’m not really sure how this code could ever have worked:

includes/JsonSchemaContent.php
	public function objectRow( $key, $val ) {
		if ( $key === '$ref' ) {
			$valParts = explode( '/', $val, 2 );
			if ( !isset( $valParts[1] ) ) {
				// Don't store or inject service objects in Content objects
				// as that breaks serialization (T286610).
				$services = MediaWikiServices::getInstance();
				$revId = (int)$valParts[1];
				$revRecord = $services->getRevisionLookup()->getRevisionById( $revId );
				$title = $revRecord->getPageAsLinkTarget();

We’ve already checked that $valParts[1] isn’t set, but then we still cast it to an int, and try to load a revision record from that ID? Is the if condition just flipped from what it should be?

I also don’t see any recent changes to the code, which is confusing.

Also, the $val parameter is documented as mixed. It can sometimes be an stdClass instance. This will trigger an error when it's passed to explode().

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits