[go: nahoru, domu]

Page MenuHomePhabricator

Test file "SandboxTest.php" not found for parallel PHPUnit in TwoColConflict
Closed, ResolvedPublic

Description

The unit run for TwoColConflict gives failure about missing file
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TwoColConflict/+/1048824
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium/23147/console

INFO:quibble.commands:>>> Start: PHPUnit split_group_0 suite (without database or standalone)
PHPUnit split_group_0 suite (without database or standalone)
composer run --timeout=0 phpunit:entrypoint -- --cache-result-file /workspace/log/.phpunit_group_{split_group_id}_databaseless.cache.json --testsuite split_group_0 --exclude-group Broken,ParserFuzz,Stub,Database,Standalone
> phpunit '--cache-result-file' '/workspace/log/.phpunit_group_{split_group_id}_databaseless.cache.json' '--testsuite' 'split_group_0' '--exclude-group' 'Broken,ParserFuzz,Stub,Database,Standalone'
Using PHP 7.4.33
Running with MediaWiki settings because there might be integration tests
PHPUnit 9.6.19 by Sebastian Bergmann and contributors.

Test file "/workspace/src/extensions/Scribunto/tests/phpunit/Engines/LuaSandbox/SandboxTest.php" not found
Script phpunit handling the phpunit event returned with error code 2
Script @phpunit was called via phpunit:entrypoint
<<< Finish: PHPUnit split_group_0 suite (without database or standalone), in 1.395 s

INFO:quibble.commands:<<< Finish: Run PHPUnit extensions suite (without database or standalone) parallel run in parallel (concurrency=7):
* PHPUnit split_group_0 suite (without database or standalone)
* PHPUnit split_group_1 suite (without database or standalone)
* PHPUnit split_group_2 suite (without database or standalone)
* PHPUnit split_group_3 suite (without database or standalone)
* PHPUnit split_group_4 suite (without database or standalone)
* PHPUnit split_group_5 suite (without database or standalone)
* PHPUnit split_group_6 suite (without database or standalone), in 1.528 s

Event Timeline

Scribunto is not cloned and seems not a dependency of the extension.

Ah - yes. That's definitely my bad. It needs a file-exists check, but I didn't get to adding that. I'll take a look - thanks for the report!

Change #1051058 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[integration/quibble@master] Parallel PHPUnit: Only run Scributo SandboxTest if Scribunto loaded

https://gerrit.wikimedia.org/r/1051058

Change #1051058 merged by jenkins-bot:

[integration/quibble@master] Parallel PHPUnit: Only run Scributo SandboxTest if Scribunto loaded

https://gerrit.wikimedia.org/r/1051058

I can't upgrade Quibble on CI since we use Buster image and PHP packages coming from sury.org which has removed support for Buster: T369146

The easiest for now is to opt out TwoColConflict from parallelism.

Change #1051701 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] zuul: disable PHPUnit parallel for TwoColConflict

https://gerrit.wikimedia.org/r/1051701

Change #1051701 merged by jenkins-bot:

[integration/config@master] zuul: disable PHPUnit parallel for TwoColConflict

https://gerrit.wikimedia.org/r/1051701

ArthurTaylor claimed this task.

This is now unblocked - the pending change (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TwoColConflict/+/1048824) has been merged. We can revisit enabling parallel testing for TwoColConflict in the future, but since all jobs run in under 7 mins, it doesn't seem an urgent priority.

Change #1053311 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: switch jobs from Quibble 1.9.1 to 1.9.3

https://gerrit.wikimedia.org/r/1053311

Change #1053311 merged by jenkins-bot:

[integration/config@master] jjb: switch jobs from Quibble 1.9.1 to 1.9.3

https://gerrit.wikimedia.org/r/1053311