[go: nahoru, domu]
Page MenuHomePhabricator
Create Task
Maniphest T368902

Enable mocha parallel testing for Wikibase API E2E tests
Closed, ResolvedPublic
Actions

Description

The Wikibase API tests CI job currently takes almost 15 minutes to run:

	mediawiki-quibble-apitests-vendor-php74 (10035): 864
		Setup: 11
		Versions: 1
		Ensure dir: '/workspace/log': 0
		Zuul clone : 90
		Submodule update: /workspace/src: 14
		Install composer dev-requires for vendor.git: 10
		Start backends: <MySQL (no socket)>: 4
		Run Post-dependency install: 0
		Install MediaWiki: 8
		npm install in /workspace/src: 2
		Start backends: <ExternalWebserver http://127.0.0.1:9413 /workspace/src> <Xvfb :94> <ChromeWebDriver :94>: 0
		Run API-Testing: 691
		PostBuildScript: 33

Most of this time (691 seconds) is spent running the API test suite, which is a mocha integration test suite.

mocha supports parallel execution with the --parallel flag. Identify which Wikibase test suites can be parallelised this way, and enable the flag for those suites.

Details

SubjectRepoBranchLines +/-
Enable parallel tests for the mocha e2e API test suitemediawiki/extensions/Wikibasemaster+81 -45
REST: Remove unused setup.js filemediawiki/extensions/Wikibasemaster+5 -20
Enable parallel tests for the mocha openapi-validation test suitemediawiki/extensions/Wikibasemaster+25 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

ArthurTaylor created this task.Jul 1 2024, 11:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2024, 11:32 AM
ArthurTaylor added a parent task: T361118: [EPIC][REPO][CLIENT] Reduce CI test runtime for Wikibase and related extensions.Jul 1 2024, 11:33 AM
ArthurTaylor added a subtask: T368903: Remove race condition in api-testing/makeTag to enable parallel testing.Jul 1 2024, 11:40 AM
ArthurTaylor moved this task from In Task Breakdown to Parent Task on the Wikidata Dev Team (Wikidata.org Slice) board.
Maintenance_bot moved this task from Incoming to Ongoing on the wmde-wikidata-tech board.Jul 1 2024, 12:29 PM
Maintenance_bot added a project: Wikidata.
ArthurTaylor moved this task from Parent Task to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.Jul 2 2024, 10:27 AM
gerritbot added a comment.Jul 2 2024, 10:28 AM

Change #1051106 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Enable parallel tests for the mocha e2e API test suite

https://gerrit.wikimedia.org/r/1051106

gerritbot added a project: Patch-For-Review.Jul 2 2024, 10:28 AM
gerritbot added a comment.Jul 2 2024, 11:45 AM

Change #1051336 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Enable parallel tests for the mocha openapi-validation test suite

https://gerrit.wikimedia.org/r/1051336

gerritbot added a comment.Jul 2 2024, 1:00 PM

Change #1051336 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Enable parallel tests for the mocha openapi-validation test suite

https://gerrit.wikimedia.org/r/1051336

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Jul 2 2024, 2:01 PM
gerritbot added a comment.Jul 2 2024, 2:24 PM

Change #1051383 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Remove unused setup.js file

https://gerrit.wikimedia.org/r/1051383

gerritbot added a comment.Jul 2 2024, 3:28 PM

Change #1051383 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove unused setup.js file

https://gerrit.wikimedia.org/r/1051383

ArthurTaylor added a comment.Jul 4 2024, 10:15 AM

The patches have reduced the runtime by over three minutes:

	mediawiki-quibble-apitests-vendor-php74 (10461): 664
		Setup: 35
		Versions: 1
		Ensure dir: '/workspace/log': 0
		Zuul clone : 101
		Submodule update: /workspace/src: 14
		Install composer dev-requires for vendor.git: 9
		Start backends: <MySQL (no socket)>: 4
		Run Post-dependency install: 0
		Install MediaWiki: 10
		npm install in /workspace/src: 0
		Start backends: <ExternalWebserver http://127.0.0.1:9413 /workspace/src> <Xvfb :94> <ChromeWebDriver :94>: 0
		Run API-Testing: 468
		PostBuildScript: 22

The api-testing and openapi-validation suites run in parallel - other extensions still run in serial. So there's some low-hanging fruit still, but mediawiki-quibble-apitests-vendor-php74 is no longer the longest-running job.

ArthurTaylor removed ArthurTaylor as the assignee of this task.Jul 4 2024, 10:16 AM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor closed subtask T368903: Remove race condition in api-testing/makeTag to enable parallel testing as Resolved.
gerritbot added a comment.Jul 4 2024, 11:09 AM

Change #1051106 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Enable parallel tests for the mocha e2e API test suite

https://gerrit.wikimedia.org/r/1051106

ArthurTaylor moved this task from Ready for Peer Review to Ready for Tech Verification on the Wikidata Dev Team (Wikidata.org Slice) board.Jul 5 2024, 8:20 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 9 2024, 8:28 PM
• Lucas_Werkmeister_WMDE closed this task as Resolved.Aug 1 2024, 1:19 PM
• Lucas_Werkmeister_WMDE assigned this task to ArthurTaylor.
• Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits