[go: nahoru, domu]
Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Adjust broker ingress parameters to support target load #1656

Merged
merged 4 commits into from
Sep 2, 2020
Merged

Adjust broker ingress parameters to support target load #1656

merged 4 commits into from
Sep 2, 2020

Conversation

yolocs
Copy link
Member
@yolocs yolocs commented Aug 31, 2020

Fixes #1600

Proposed Changes

  • Default ingress CPU to 2000m and memory to 2000Mi
  • Adjust default HPA parameters accordingly
  • Default pubsub publish buffer limit to 300Mi
  • Loosen probe check threshold to 5 times

See reasoning in the issue.

Release Note

- Default ingress CPU to 2000m and memory to 2000Mi
- Adjust default HPA parameters accordingly
- Default pubsub publish buffer limit to 300Mi
- Loosen probe check threshold to 5 times

Docs

@google-cla google-cla bot added the cla: yes (override cla status due to multiple authors bug) label Aug 31, 2020
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-integration-tests 2020-08-31 23:58:25.437 +0000 UTC 1/3

Automatically retrying due to test flakiness...
/test pull-google-knative-gcp-integration-tests

liu-cong
liu-cong reviewed Sep 1, 2020
View reviewed changes
Copy link
Contributor
@liu-cong liu-cong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold for the nit

cmd/broker/ingress/main.go Show resolved Hide resolved
@yolocs
Copy link
Member Author
yolocs commented Sep 2, 2020

/unhold

@liu-cong
Copy link
Contributor
liu-cong commented Sep 2, 2020

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liu-cong, yolocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit ad79cd4 into google:master Sep 2, 2020
danyinggu pushed a commit to danyinggu/knative-gcp that referenced this pull request Nov 11, 2020
@yolocs @danyinggu
Cherry pick google#1656
03a56c6
@danyinggu danyinggu mentioned this pull request Nov 11, 2020
Merged
knative-prow-robot pushed a commit that referenced this pull request Nov 11, 2020
@danyinggu @yolocs
Cherry pick Brokercell annotation updates to release 0.17 (#1904)
19d88c5 
* Cherry pick brokercell istio

* Cherry pick #1656

* Cherry pick #1775

Co-authored-by: cshou <cshou@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-cong liu-cong liu-cong left review comments

@capri-xiyue capri-xiyue Awaiting requested review from capri-xiyue

Assignees

@liu-cong liu-cong

Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust broker ingress resource requirements to meet default events per second target
4 participants
@yolocs @knative-test-reporter-robot @liu-cong @knative-prow-robot