[go: nahoru, domu]
Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Cherry pick Brokercell annotation updates to release 0.17 #1904

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Cherry pick Brokercell annotation updates to release 0.17 #1904

merged 3 commits into from
Nov 11, 2020

Conversation

danyinggu
Copy link
Contributor
@danyinggu danyinggu commented Nov 11, 2020 •
edited
Loading

Cherry pick #1736, #1656, #1775

Proposed Changes

Release Note

Docs

@google-cla google-cla bot added the cla: yes (override cla status due to multiple authors bug) label Nov 11, 2020
@knative-prow-robot
Copy link
Contributor

@danyinggu: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-upgrade-tests 41fe47c link /test pull-google-knative-gcp-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/brokercell/brokercell.go 94.7% 94.5% -0.2

@yolocs
Copy link
Member
yolocs commented Nov 11, 2020

/lgtm

@nlopezgi
Copy link
Contributor

/approve

1 similar comment
@yolocs
Copy link
Member
yolocs commented Nov 11, 2020

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danyinggu, nlopezgi, yolocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 19d88c5 into google:release-0.17 Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nlopezgi nlopezgi Awaiting requested review from nlopezgi

@yolocs yolocs Awaiting requested review from yolocs

Assignees

@yolocs yolocs

Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danyinggu @knative-prow-robot @knative-metrics-robot @yolocs @nlopezgi