This repository has been archived by the owner on Jun 19, 2022. It is now read-only.
Add rollout restart time annotation to Brokercell and update Brokercell deployments #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yolocs
reviewed
Sep 28, 2020
|
FYI: I want to do some further research about the length to be set in deployment's progressDeadlineSeconds, so I didn't change it by intention. I will change that in a follow-up PR. |
liu-cong
reviewed
Sep 29, 2020
grantr
reviewed
Sep 29, 2020
liu-cong
reviewed
Sep 29, 2020
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danyinggu, liu-cong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
nlopezgi
pushed a commit
to nlopezgi/knative-gcp
that referenced
this pull request
Oct 27, 2020
…ll deployments (google#1775) * Update docs for CloudBuildSource to use v1 * Add rollout restart time annotation to brokercell * add empty line * fix format * Rename annotation keys
nlopezgi
pushed a commit
to nlopezgi/knative-gcp
that referenced
this pull request
Oct 27, 2020
…ll deployments (google#1775) * Update docs for CloudBuildSource to use v1 * Add rollout restart time annotation to brokercell * add empty line * fix format * Rename annotation keys
danyinggu
added a commit
to danyinggu/knative-gcp
that referenced
this pull request
Nov 11, 2020
knative-prow-robot
pushed a commit
that referenced
this pull request
Nov 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
Release Note
Docs