Functions Interop #2113
Functions Interop #2113
Conversation
Convert Firebase Functions to use the Auth Interop pod
I also removed a doubly-defined `FRAMEWORK_SEARCH_PATHS`
I also cleaned up some more project settings
|
I now have Travis passing all the tests on this PR. Please have a look. |
|
Looks like there's a Travis issue: https://travis-ci.org/firebase/firebase-ios-sdk/jobs/460759039#L7046 |
|
Yeah, seems I removed too much of my previous PR. I'm not 100% which path included the container header, but I'll fiddle with it and look at where CocoaPods puts everything. |
I also attempted moving the FakeApp class to the test targets and further simplified the project file.
I also moved the Podfile pods to the app target rather than the top-level
- Remove `FUNFakeApp` from app target + Add `FUNFakeApp` to test targets + Add `$(inherited)` to `HEADER_SEARCH_PATH` as per CocoaPods warning + Add `$(SRCROOT)/../../Firebase/Core/Private` to find `FIRComponentContainerInternal` header ~ Change import from frameworks import to regular import
|
This should ready to review again. I was able to get everything compiling and passing once I could iterate quickly with |
|
Hi Bryan, could you have a look at this CL which moves Functions to the new Interop platform. |
| FIRFunctions *functions = [[FIRFunctions alloc] | ||
| initWithApp:app | ||
| region:@"my-region" | ||
| auth:[[FIRAuthInteropFake alloc] initWithToken:nil userID:nil error:nil]]; |
There was a problem hiding this comment.
I don't understand why this passes. Shouldn't functions be using the FIRAuthInteropFake's token instead of the one passed into the FUNFakeApp?
There was a problem hiding this comment.
I'm also unsure how this was passing.
It looks like callFunction would have an empty Authorization header, but maybe the mock server still returns an empty data response with a 200 OK?
There was a problem hiding this comment.
Actually, I bet it wasn't passing. Travis doesn't run the integration tests on PRs, just the master branch. I'll run them locally to make sure they're passing now.
There was a problem hiding this comment.
I'm having difficulty running the integration tests. I get many warnings when running Backend/start.sh instructions. See this gist of the output I get.
There was a problem hiding this comment.
I changed my system to node 8, and ran through the suggestions it printed out, and it seems as though it's connecting to the emulator, but I'm not sure it's behaving as expected.
For example, the testData test case gets the error: Function dataTest in location my-region in project functions-integration-test does not exist in its FIRHTTPSCallableResult callback.
From the emulator's output, it looks like my-region isn't what's expected, but rather us-central1 since it outputs http://localhost:5005/functions-integration-test/us-central1/dataTest as the resource.
Switching the tests to using us-central1 as the region has all the tests but one passing. The testNull attempts to wait on an expectation twice, which is an API violation that throws an error.
Are the integration tests expected to pass? I'm not sure how they would on master without the region change and the duplicate waitForExpectation: call.
There was a problem hiding this comment.
It appears as though the last green run of master compiled the integration tests, but only ran the unit tests.
It seems as though the integration tests aren't being run on Travis.
I'll open an internal bug to fix and enable theses.
There was a problem hiding this comment.
From the emulator's output, it looks like my-region isn't what's expected, but rather us-central1
Yes, the shell script in Backend/ that installs the functions says to install them in us-central1. Not sure when that broke.
- Delete `FUNFakeApp` + Add `FIRAuthInteropFake` to test targets ~ Update initializer to use projectID instead of app
* Set the region to the expected value * Update node package.json to latest versions
* master: (26 commits) Functions Interop (#2113) Add a travis cron job for CocoaPod symbol collision testing (#2154) Save schema version on downgrade, add test to verify (#2153) Silence Storage Unit Test `nil` warning. (#2150) Update versions for Release 5.14.0 (#2145) gRPC: fix cases where gRPC call could be finished twice (#2146) Fix Swizzler test warnings (#2144) Update Auth CHANGELOG.md (#2128) Make fuzz tests optional until they pass (#2143) Add support of Game Center sign in (#2127) Add test for deprecated FDLURLComponents init API. (#2133) fix a typo in integration test (#2131) Make fuzzing less verbose to avoid exceeding Travis log limit (#2126) Move to `domainURIPrefix` for FIRDynamicLinkComponents (#2119) Carthage instructions for new gRPCCertificates.bundle location (#2132) Fix pod lib lint GoogleUtilities.podspec --use-libraries regression (#2130) Avoid using default FIROptions directly. (#2124) Changelog entry for LRU GC (#2122) Revert "Add Firebase Source to Header Search Path" (#2123) Custom fdl domain (#2121) ...
Convert Firebase Functions to use the Auth Interop pod