Make fuzzing less verbose to avoid exceeding Travis log limit #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var-const
commented
Nov 27, 2018
| @@ -110,7 +114,8 @@ for i in "${!all_fuzzing_targets[@]}"; do | |||
| echo "Error: Fuzz testing for target ${fuzzing_target} failed." | |||
| script_return=${EXIT_FAILURE} | |||
| echo "Fuzzing logs:" | |||
| echo "${fuzzing_results}" | |||
| echo "${fuzzing_results}" | tail -n${LINES_TO_OUTPUT} | |||
| echo "End fuzzing logs" | |||
There was a problem hiding this comment.
This helps distinguish where the logs from the next test run start.
rsgowman
approved these changes
Nov 28, 2018
| @@ -110,7 +114,8 @@ for i in "${!all_fuzzing_targets[@]}"; do | |||
| echo "Error: Fuzz testing for target ${fuzzing_target} failed." | |||
| script_return=${EXIT_FAILURE} | |||
| echo "Fuzzing logs:" | |||
| echo "${fuzzing_results}" | |||
| echo "${fuzzing_results}" | tail -n${LINES_TO_OUTPUT} | |||
There was a problem hiding this comment.
Somewhat related question: The output here is generated by the run_xcode_fuzzing function, which calls xcodebuild. Clearly, it generates stdout, which we assign to this variable. Does it also generate stderr? If so, we might still end up with an overly long log.
There was a problem hiding this comment.
I'm not sure if it generates stderr -- at the very least, I could see a significant reduction in log length when running locally. I'd prefer to submit as is and do a followup.
bstpierr
added a commit
that referenced
this pull request
Dec 6, 2018
* master: (26 commits) Functions Interop (#2113) Add a travis cron job for CocoaPod symbol collision testing (#2154) Save schema version on downgrade, add test to verify (#2153) Silence Storage Unit Test `nil` warning. (#2150) Update versions for Release 5.14.0 (#2145) gRPC: fix cases where gRPC call could be finished twice (#2146) Fix Swizzler test warnings (#2144) Update Auth CHANGELOG.md (#2128) Make fuzz tests optional until they pass (#2143) Add support of Game Center sign in (#2127) Add test for deprecated FDLURLComponents init API. (#2133) fix a typo in integration test (#2131) Make fuzzing less verbose to avoid exceeding Travis log limit (#2126) Move to `domainURIPrefix` for FIRDynamicLinkComponents (#2119) Carthage instructions for new gRPCCertificates.bundle location (#2132) Fix pod lib lint GoogleUtilities.podspec --use-libraries regression (#2130) Avoid using default FIROptions directly. (#2124) Changelog entry for LRU GC (#2122) Revert "Add Firebase Source to Header Search Path" (#2123) Custom fdl domain (#2121) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuzzing triggers many assertion failures, which generates enormous log output. AFAIK, there is no way to make
NSAssertionHandlernot write to log, and the assertions themselves are valid. Thus, implement a workaround: only output the last part of the logs in Travis, in order to avoid exceeding the log size limit (4 Mb).