[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog entry for LRU GC #2122

Merged
merged 5 commits into from
Nov 27, 2018
Merged

Changelog entry for LRU GC #2122

merged 5 commits into from
Nov 27, 2018

Conversation

gsoltis
Copy link
@gsoltis gsoltis commented Nov 27, 2018

No description provided.

@gsoltis gsoltis requested a review from wilhuff November 27, 2018 00:27
wilhuff
wilhuff reviewed Nov 27, 2018
View reviewed changes
Firestore/CHANGELOG.md Outdated Show resolved Hide resolved
Firestore/CHANGELOG.md Outdated Show resolved Hide resolved
wilhuff
wilhuff approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor
@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alexg33 any thoughts before this goes into the release notes?

alexg33
alexg33 reviewed Nov 27, 2018
View reviewed changes
Copy link
Contributor
@alexg33 alexg33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry — had a meeting and came to the review game late. Added a minor tweak, but you can safely ignore if you feel so inclined.

@gsoltis gsoltis merged commit 471c23f into master Nov 27, 2018
@gsoltis gsoltis deleted the gsoltis/lru_changelog branch November 27, 2018 20:02
bstpierr added a commit that referenced this pull request Dec 6, 2018
@bstpierr
Merge branch 'master' into bs-appauthcleanup
c4ae7f4 
* master: (26 commits)
  Functions Interop (#2113)
  Add a travis cron job for CocoaPod symbol collision testing (#2154)
  Save schema version on downgrade, add test to verify (#2153)
  Silence Storage Unit Test `nil` warning. (#2150)
  Update versions for Release 5.14.0 (#2145)
  gRPC: fix cases where gRPC call could be finished twice (#2146)
  Fix Swizzler test warnings (#2144)
  Update Auth CHANGELOG.md (#2128)
  Make fuzz tests optional until they pass (#2143)
  Add support of Game Center sign in (#2127)
  Add test for deprecated FDLURLComponents init API. (#2133)
  fix a typo in integration test (#2131)
  Make fuzzing less verbose to avoid exceeding Travis log limit (#2126)
  Move to `domainURIPrefix` for FIRDynamicLinkComponents (#2119)
  Carthage instructions for new gRPCCertificates.bundle location (#2132)
  Fix pod lib lint GoogleUtilities.podspec --use-libraries regression (#2130)
  Avoid using default FIROptions directly. (#2124)
  Changelog entry for LRU GC (#2122)
  Revert "Add Firebase Source to Header Search Path" (#2123)
  Custom fdl domain (#2121)
  ...
@firebase firebase locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexg33 alexg33 alexg33 left review comments

@wilhuff wilhuff wilhuff approved these changes

Assignees

@wilhuff wilhuff

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gsoltis @wilhuff @alexg33 @googlebot