[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Swizzler test warnings #2144

Merged
merged 2 commits into from
Dec 5, 2018
Merged

Fix Swizzler test warnings #2144

merged 2 commits into from
Dec 5, 2018

Conversation

paulb777
Copy link
Member
@paulb777 paulb777 commented Dec 4, 2018

No description provided.

@tejasd
Copy link
Contributor
tejasd commented Dec 4, 2018

Travis doesn't run the GULAppDelegateSwizzler tests due to flakiness - can you confirm these work as expected on an internal test run?

@paulb777
Copy link
Member Author
paulb777 commented Dec 4, 2018

Confirmed. Thanks @tejasd

@paulb777 paulb777 merged commit 4f4d683 into master Dec 5, 2018
@paulb777 paulb777 deleted the pb-swizzling-test-warnings branch December 5, 2018 00:09
bstpierr added a commit that referenced this pull request Dec 6, 2018
* master: (26 commits)
  Functions Interop (#2113)
  Add a travis cron job for CocoaPod symbol collision testing (#2154)
  Save schema version on downgrade, add test to verify (#2153)
  Silence Storage Unit Test `nil` warning. (#2150)
  Update versions for Release 5.14.0 (#2145)
  gRPC: fix cases where gRPC call could be finished twice (#2146)
  Fix Swizzler test warnings (#2144)
  Update Auth CHANGELOG.md (#2128)
  Make fuzz tests optional until they pass (#2143)
  Add support of Game Center sign in (#2127)
  Add test for deprecated FDLURLComponents init API. (#2133)
  fix a typo in integration test (#2131)
  Make fuzzing less verbose to avoid exceeding Travis log limit (#2126)
  Move to `domainURIPrefix` for FIRDynamicLinkComponents (#2119)
  Carthage instructions for new gRPCCertificates.bundle location (#2132)
  Fix pod lib lint GoogleUtilities.podspec --use-libraries regression (#2130)
  Avoid using default FIROptions directly. (#2124)
  Changelog entry for LRU GC (#2122)
  Revert "Add Firebase Source to Header Search Path" (#2123)
  Custom fdl domain (#2121)
  ...
@firebase firebase locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants